Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drilling on the categorical xaxis on the stacked barchart v2 #21844

Merged
merged 2 commits into from
Oct 18, 2022
Merged

fix: drilling on the categorical xaxis on the stacked barchart v2 #21844

merged 2 commits into from
Oct 18, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Oct 18, 2022 •
edited
Loading

SUMMARY

Currently, if the GENERIC_CHART_AXES FF is enabled, the drill-to-detail on the dashboard will not generate correct filters. it because of using a temporal column logic to generate filters rather than a categorical column to do that.

...and take a little bit refactoring is that move AxisType into @superset-ui/core.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

drilling.on.xaxis.mov

Before

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie changed the title fix: categorical xaxis on the stacked barchart v2 fix: drilling on the categorical xaxis on the stacked barchart v2 Oct 18, 2022
@zhaoyongjie zhaoyongjie mentioned this pull request Oct 18, 2022
Merged
9 tasks
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #21844 (80a5a1b) into master (df3b5a8) will increase coverage by 0.06%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master   #21844      +/-   ##
==========================================
+ Coverage   66.85%   66.91%   +0.06%     
==========================================
  Files        1805     1805              
  Lines       69061    69057       -4     
  Branches     7369     7373       +4     
==========================================
+ Hits        46169    46211      +42     
+ Misses      20995    20940      -55     
- Partials     1897     1906       +9
Flag Coverage Δ
javascript 53.33% <11.11%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../packages/superset-ui-core/src/chart/types/Base.ts 100.00% <ø> (ø)
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% <0.00%> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 53.57% <ø> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 50.00% <ø> (ø)
...ugins/plugin-chart-echarts/src/utils/annotation.ts 86.27% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/utils/series.ts 84.29% <50.00%> (ø)
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx 75.00% <0.00%> (-11.96%) ⬇️
...et-frontend/src/dashboard/actions/dashboardInfo.ts 50.00% <0.00%> (-11.54%) ⬇️
...perset-frontend/src/views/CRUD/alert/AlertList.tsx 59.63% <0.00%> (-2.87%) ⬇️
.../src/dashboard/components/gridComponents/Chart.jsx 53.57% <0.00%> (-1.48%) ⬇️
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

michael-s-molina
michael-s-molina approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit f41d0b0 into apache:master Oct 18, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaoyongjie @michael-s-molina @mistercrunch